Skip to content

fix: Array Field width css #39463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2025
Merged

fix: Array Field width css #39463

merged 2 commits into from
Feb 27, 2025

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented Feb 27, 2025 •
edited by github-actions bot
Loading

Description

Updates the CSS rule missed while updating this change that renders contents of the Array field in a very limited space

Before
Screenshot 2025-02-27 at 11 15 45 AM

After
Screenshot 2025-02-27 at 11 15 24 AM

Fixes #39452

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13561110465
Commit: f8d8ceb
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Thu, 27 Feb 2025 08:10:32 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

Summary by CodeRabbit

  • Style
    • Adjusted the component layout to expand fully within its container, ensuring improved visual consistency and better integration with surrounding elements.
    • Simplified styling properties for enhanced flexibility and customization.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2025 •
edited
Loading

Walkthrough

The change updates the width setting of the PrimaryBox styled component in the FieldArrayControl.tsx file. The width has been modified from min-content to 100%, allowing the component to occupy the full width of its parent container. Additionally, the customStyles property in the NestedComponents function has been simplified, removing fixed width constraints for better flexibility. No public API or exported entity declarations were altered.

Changes

File Path Change Summary
app/.../FieldArrayControl.tsx Updated PrimaryBox width from min-content to 100% for full-width display; simplified customStyles assignment; removed width constraints for dropdowns in SecondaryBox.

Possibly related PRs

Poem

In the realm of code so bright,
A tiny tweak set things just right.
From a snug min-content plight,
To a full-width, open light.
Cheers to a layout that's in flight!

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6c44ac and f8d8ceb.

📒 Files selected for processing (1)
  • app/client/src/components/formControls/FieldArrayControl.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/client/src/components/formControls/FieldArrayControl.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-build / client-build
  • GitHub Check: client-prettier / prettier-check

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hetunandu
Copy link
Member Author

/build-deploy-preview

@github-actions github-actions bot added Bug Something isn't working Community Reported issues reported by community members Integrations Product Issues related to a specific integration Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Open AI Integration Issues related to the open AI integration Production Query & JS Pod Issues related to the query & JS Pod Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE labels Feb 27, 2025
@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13559767016.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 39463.
recreate: .

NilanshBansal
NilanshBansal previously approved these changes Feb 27, 2025
View reviewed changes
coderabbitai[bot]
coderabbitai bot reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
app/client/src/components/formControls/FieldArrayControl.tsx (1)

17-20: Width adjustment improves layout consistency.

Changing the width from min-content to 100% ensures the array field properly expands to fill its container. This fixes the limited space issue referenced in PR #39452.

Consider adding a comment explaining why this specific width value is needed to prevent future regressions.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 876e58e and a6c44ac.

📒 Files selected for processing (1)
  • app/client/src/components/formControls/FieldArrayControl.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-build / client-build
  • GitHub Check: client-prettier / prettier-check

@hetunandu hetunandu added the ok-to-test Required label for CI label Feb 27, 2025
@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-39463.dp.appsmith.com

vivek-appsmith
vivek-appsmith previously approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@vivek-appsmith vivek-appsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hetunandu
Copy link
Member Author

/build-deploy-preview

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13561118643.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 39463.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-39463.dp.appsmith.com

dvj1988
dvj1988 approved these changes Feb 27, 2025
View reviewed changes
Copy link

@dvj1988 dvj1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hetunandu hetunandu merged commit 7aabb93 into release Feb 27, 2025
45 checks passed
@hetunandu hetunandu deleted the fix/array-field-width branch February 27, 2025 08:32
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Apr 12, 2025
@hetunandu
fix: Array Field width css (appsmithorg#39463)
94ce03c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Nikhil-Nandagopal Nikhil-Nandagopal Nikhil-Nandagopal left review comments

@NilanshBansal NilanshBansal NilanshBansal left review comments

@vivek-appsmith vivek-appsmith vivek-appsmith left review comments

+1 more reviewer

@dvj1988 dvj1988 dvj1988 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug Something isn't working Community Reported issues reported by community members Integrations Product Issues related to a specific integration Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Open AI Integration Issues related to the open AI integration Production Query & JS Pod Issues related to the query & JS Pod Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Input boxes for ChatGPT Messages are very small and I can't see what is written.
5 participants
@hetunandu @Nikhil-Nandagopal @dvj1988 @NilanshBansal @vivek-appsmith