fix: Adding a style to update the width of App settings #39456

ankitakinger · 2025-02-26T14:33:31Z

Description

Adding a style to update the width of App settings

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13546298402
Commit: 284bde2
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Wed, 26 Feb 2025 15:33:13 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Style
- Adjusted the left-panel layout so that components now stack vertically, resulting in a clearer, more organized display.

coderabbitai · 2025-02-26T14:33:39Z

Walkthrough

A new property flexDirection="column" was added to the Flex component within the LeftPane component. This change alters the layout to stack child elements vertically while keeping the overall structure and functionality intact.

Changes

File Path	Change Summary
app/client/src/pages/AppIDE/.../LeftPane.tsx	Added `flexDirection="column"` to the `Flex` component to update layout direction.

Suggested labels

Bug, ok-to-test, IDE Product, Task

Suggested reviewers

hetunandu
alex-golovanov

Poem

A column now leads the way,
Stacking elements in a fresh display.
Lines of code neatly align with flair,
A subtle shift built with care.
Code sings its silent ode to change!

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 477cc8a and 284bde2.

📒 Files selected for processing (1)

app/client/src/pages/AppIDE/layouts/routers/LeftPane.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: perform-test / rts-build / build
GitHub Check: perform-test / client-build / client-build
GitHub Check: perform-test / server-build / server-unit-tests
GitHub Check: client-prettier / prettier-check
GitHub Check: client-lint / client-lint
GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
GitHub Check: client-unit-tests / client-unit-tests
GitHub Check: client-build / client-build

🔇 Additional comments (1)

app/client/src/pages/AppIDE/layouts/routers/LeftPane.tsx (1)

48-54: Approved change that aligns with the PR objective.

Adding flexDirection="column" to the Flex component changes the layout from horizontal to vertical stacking of child elements, which addresses the width issue in App settings mentioned in the PR objective. This is a simple yet effective styling fix.

✨ Finishing Touches

📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ankitakinger · 2025-02-26T14:33:56Z

/build-deploy-preview skip-tests=true

github-actions · 2025-02-26T14:34:23Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13546309822.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 39456.
recreate: .

github-actions · 2025-02-26T14:48:12Z

Deploy-Preview-URL: https://ce-39456.dp.appsmith.com

## Description Adding a style to update the width of App settings Fixes [#39454](#39454) ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13546298402> > Commit: 284bde2 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13546298402&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 26 Feb 2025 15:33:13 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **Style** - Adjusted the left-panel layout so that components now stack vertically, resulting in a clearer, more organized display.

…ings-fix fix: Adding a style to update the width of App settings (#39456)

…39456) ## Description Adding a style to update the width of App settings Fixes [appsmithorg#39454](appsmithorg#39454) ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13546298402> > Commit: 284bde2 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13546298402&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 26 Feb 2025 15:33:13 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **Style** - Adjusted the left-panel layout so that components now stack vertically, resulting in a clearer, more organized display.

fixing the width of app settings

284bde2

ankitakinger requested a review from hetunandu February 26, 2025 14:33

ankitakinger added the ok-to-test Required label for CI label Feb 26, 2025

github-actions bot added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Production Release Blocker This issue must be resolved before the release labels Feb 26, 2025

hetunandu approved these changes Feb 26, 2025

View reviewed changes

ankitakinger merged commit 536ea5d into release Feb 26, 2025
47 checks passed

ankitakinger deleted the fix/app-settings branch February 26, 2025 17:09

hetunandu added a commit that referenced this pull request Feb 27, 2025

Merge pull request #39457 from appsmithorg/chore/cherry-pick-app-sett…

372fb46

…ings-fix fix: Adding a style to update the width of App settings (#39456)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Adding a style to update the width of App settings #39456

fix: Adding a style to update the width of App settings #39456

Uh oh!

ankitakinger commented Feb 26, 2025 •

edited by github-actions bot

Loading

Uh oh!

coderabbitai bot commented Feb 26, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

ankitakinger commented Feb 26, 2025

Uh oh!

github-actions bot commented Feb 26, 2025

Uh oh!

github-actions bot commented Feb 26, 2025

Uh oh!

Uh oh!

Uh oh!

fix: Adding a style to update the width of App settings #39456

fix: Adding a style to update the width of App settings #39456

Uh oh!

Conversation

ankitakinger commented Feb 26, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

ankitakinger commented Feb 26, 2025

Uh oh!

github-actions bot commented Feb 26, 2025

Uh oh!

github-actions bot commented Feb 26, 2025

Uh oh!

Uh oh!

Uh oh!

ankitakinger commented Feb 26, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Feb 26, 2025 •

edited

Loading