fix: Env for disabling Keycloak is set incorrect

[sharat87]

Description

This env variable value isn't doing what it looks like it should, that is, to disable Keycloak. It's value is showing up as "1" and 1 and so Keycloak is not being disabled.

But now since we want embedded Keycloak on DPs, we're "fixing" this by removing this env variable to avoid confusion later.

Automation

/test sanity

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Chores
  • Modified the deployment configuration to remove an override that previously disabled the built-in authentication service. As a result, the integrated authentication system now activates by default, offering a more streamlined user management experience. Users deploying the solution may notice this service is enabled unless configured otherwise.

[coderabbitai]

Walkthrough

The deployment script deploy_preview.sh was updated to remove the explicit setting of the parameter applicationConfig.APPSMITH_DISABLE_EMBEDDED_KEYCLOAK. With this change, the Helm chart deployment command no longer forces the embedded Keycloak feature to be disabled, allowing default chart values to determine its behavior. Other aspects of the deployment configuration remain intact.

Changes

File	Change Summary
scripts/deploy_preview.sh	Removed --set applicationConfig.APPSMITH_DISABLE_EMBEDDED_KEYCLOAK="1" parameter from Helm command.

Possibly related PRs

• fix: update dp builder #34203: Similar modifications affecting the Helm deployment command in deploy_preview.sh, though with different parameters.

Suggested labels

Bug, ok-to-test

Suggested reviewers

• pratapaprasanna

Poem

Lines of code now dance and play,
A parameter removed to light the way.
Helm charts rely on defaults anew,
Embedded Keycloak finds a path that's true.
In every merge, the code sings high—
A subtle shift under the digital sky.
🚀 Happy commits and smooth deploys!

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6604f36 and 5aa6588.

📒 Files selected for processing (1)

• scripts/deploy_preview.sh (0 hunks)

💤 Files with no reviewable changes (1)

• scripts/deploy_preview.sh

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.