Fix column order in table widget #3755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ordering from the table headers, with a hidden column in between the start and end index of the dragged column
|
No changes to code coverage between the base branch and the head branch |
|
No changes to code coverage between the base branch and the head branch |
hetunandu
reviewed
Mar 30, 2021
app/client/src/components/propertyControls/PrimaryColumnsControl.tsx
Outdated
Show resolved
Hide resolved
app/client/src/components/designSystems/appsmith/TableComponent/TableUtilities.tsx
Outdated
Show resolved
Hide resolved
sheelpriy
reviewed
Mar 30, 2021
app/client/src/components/designSystems/appsmith/TableComponent/index.tsx
Outdated
Show resolved
Hide resolved
Test coverage results 🧪
|
|
/ok-to-test sha=7a58715 |
mohanarpit
previously approved these changes
Apr 1, 2021
kaushik94
previously approved these changes
Apr 1, 2021
Test coverage results 🧪
|
Nikhil-Nandagopal
approved these changes
Apr 6, 2021
rajatagrawal
pushed a commit
that referenced
this pull request
Apr 17, 2024
chore: resolve sync conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue where table column order list gets duplicate values when reordering from the table headers, with a hidden column in between the start and end index of the dragged column
Fixes #3754 #3743 #3552
Type of change
How Has This Been Tested?
Checklist: