Clear OAuth tokens for forked datasources #3609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidhi-nair
previously approved these changes
Mar 18, 2021
nidhi-nair
reviewed
Mar 18, 2021
| return Flux.fromIterable(existingDatasources) | ||
| .map(ds -> { | ||
| ds.getDatasourceConfiguration().getAuthentication().setIsAuthorized(null); |
There was a problem hiding this comment.
Will ds here always have a datasource configuration?
There was a problem hiding this comment.
Nope. Nice catch :)
Fixed.
nidhi-nair
approved these changes
Mar 18, 2021
nidhi-nair
added a commit
that referenced
this pull request
Mar 19, 2021
* add ellipsis to org name in settings * added tests, documentation and better naming convention * fix document icon styles * update title * Fix placeholder * Enhancement: Virtualized Query Editor Table (#3496) * add react-window on react-table * remove .vscode launch.json * add cellwrapper * fix height issue in virtualized table * useBlockLayout in Table * add border-right on table row Co-authored-by: Pawan Kumar <[email protected]> * Remove page save event from frontend * Fix success message for single user invite and multiple user invite (#3591) * Fixed error message for single user invite * updated success message for single user invite and created tests * use state to detect and update the number of users invited * removing unnecessary lines * typo * Clear OAuth tokens for forked datasources (#3609) * Clear OAuth tokens for forked datasources * Fix datasource duplicate finder in light of oAuth tokens * Fix potential NPE * Added logs and analytics (#3622) * Added logs and analytics * Fix in error string Co-authored-by: Shri <[email protected]> * Review fixes :) Co-authored-by: Shri <[email protected]> Co-authored-by: Shri <[email protected]> * udpated tests (#3617) Co-authored-by: nandan.anantharamu <[email protected]> * Fix container widget dynamicBindingPathList correction (#3619) * Create .deepsource.toml (#3593) Co-authored-by: Automated Github Action <[email protected]> Co-authored-by: Kaushik Varanasi <[email protected]> Co-authored-by: Rishabh Saxena <[email protected]> Co-authored-by: Pawan Kumar <[email protected]> Co-authored-by: hetunandu <[email protected]> Co-authored-by: Shri <[email protected]> Co-authored-by: Nidhi <[email protected]> Co-authored-by: Nikhil Nandagopal <[email protected]> Co-authored-by: NandanAnantharamu <[email protected]> Co-authored-by: nandan.anantharamu <[email protected]> Co-authored-by: Hetu Nandu <[email protected]> Co-authored-by: Moulik Aggarwal <[email protected]> Co-authored-by: Automated Github Action <[email protected]>
sondermanish
pushed a commit
that referenced
this pull request
Mar 6, 2024
Continuing refactor needed for removing QueryDSL. Details at #31269.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.