Skip to content

Provide non client certificate based SSL support for Mysql, Mongo, Postgres plugins. #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 19, 2021
Merged

Provide non client certificate based SSL support for Mysql, Mongo, Postgres plugins. #3518

merged 14 commits into from
Mar 19, 2021

Conversation

sumitsum
Copy link
Contributor

@sumitsum sumitsum commented Mar 12, 2021 •
edited
Loading

Description

  • Provide non client certificate based SSL support for Mysql, Mongo, Postgres plugins.
  • Added a new option default, apart from the the SSL mode types supported by the driver. Default means that go with whatever default configuration driver provides.
  • Migration changes take approx 4 sec on my local setup.

Fixes #2345 #3185

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Junit TCs for all three plugins
  • manual
    Query names indicate SSL mode:
Screen.Recording.2021-03-12.at.3.36.14.PM.mov
Screen.Recording.2021-03-12.at.3.52.34.PM.mov

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sumitsum sumitsum changed the title Feature/add partial ssl support to mysql postgres mongo plugins Provide non certificate based SSL support for Mysql, Mongo, Postgres plugins. Mar 12, 2021
@sumitsum sumitsum changed the title Provide non certificate based SSL support for Mysql, Mongo, Postgres plugins. Provide non client certificate based SSL support for Mysql, Mongo, Postgres plugins. Mar 12, 2021
sumitsum added 2 commits March 12, 2021 16:36
@sumitsum
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
884ca82 
…o feature/add_partial_ssl_support_to_mysql_postgres_mongo_plugins
@sumitsum
fix TC
75afdaa
sharat87
sharat87 reviewed Mar 18, 2021
View reviewed changes
sumitsum and others added 7 commits March 19, 2021 08:59
@sumitsum @sharat87
Update app/server/appsmith-plugins/mongoPlugin/src/main/java/com/exte…
7658fb6 
…rnal/plugins/MongoPlugin.java

Co-authored-by: Shri <[email protected]>
@sumitsum @sharat87
Update app/server/appsmith-server/src/main/java/com/appsmith/server/m…
d8dc96c 
…igrations/DatabaseChangelog.java

Co-authored-by: Shri <[email protected]>
@sumitsum @sharat87
Update app/server/appsmith-server/src/main/java/com/appsmith/server/m…
c08c17b 
…igrations/DatabaseChangelog.java

Co-authored-by: Shri <[email protected]>
@sumitsum @sharat87
Update app/server/appsmith-server/src/main/java/com/appsmith/server/m…
e77846f 
…igrations/DatabaseChangelog.java

Co-authored-by: Shri <[email protected]>
@sumitsum @sharat87
Update app/server/appsmith-server/src/main/java/com/appsmith/server/m…
2ed4db6 
…igrations/DatabaseChangelog.java

Co-authored-by: Shri <[email protected]>
@sumitsum @sharat87
Update app/server/appsmith-server/src/main/java/com/appsmith/server/m…
8bc7a8e 
…igrations/DatabaseChangelog.java

Co-authored-by: Shri <[email protected]>
@sumitsum
Merge branch 'release' into feature/add_partial_ssl_support_to_mysql_…
e175688 
…postgres_mongo_plugins
@sumitsum sumitsum requested a review from sharat87 March 19, 2021 04:29
@sumitsum sumitsum merged commit 38c5639 into release Mar 19, 2021
@sumitsum sumitsum deleted the feature/add_partial_ssl_support_to_mysql_postgres_mongo_plugins branch March 19, 2021 09:33
@sumitsum sumitsum linked an issue Mar 22, 2021 that may be closed by this pull request
[Feature] Enable SSL support in mongo plugin #3185
Closed
This was referenced Mar 22, 2021
Closed
Closed
sondermanish pushed a commit that referenced this pull request Mar 6, 2024
@nidhi-nair
Reverted incorrect renaming (#3518)
3739437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharat87 sharat87 sharat87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Enable SSL support in mongo plugin [Bug] Need to enable SSL options in mysql plugin
2 participants
@sumitsum @sharat87