Adding JSON intelligent substitution for Rest Api plugin #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

trishaanand merged 12 commits into release from feature/json-intelligent-substitution

Mar 11, 2021

Contributor

trishaanand commented Mar 10, 2021

No description provided.

trishaanand added 9 commits

March 10, 2021 14:04


          POC : null value getting handled correctly

c32b343


          Refactor code. Tested with and without quotes. This is working! Woohoo!

d23d0b1


          Added support for mustache binding to include json objects and arrays

7b4d23c


          Added test for smart substitution.

4cd4e3f


          Added setting to turn on/off smart substitutions in Rest API plugin

de41963


          Handling turning on smart json substitution

9961ed1


          Added error handling

25aa5f4


          Added config to turn on smart substitution in JSON to make the tests …

a0d2f16

…pass now


          Adding a beta tag to the API setting.

becde5d

sumitsum reviewed

View reviewed changes

app/client/src/mockResponses/ActionSettings.tsx Outdated Show resolved Hide resolved

sumitsum reviewed

View reviewed changes

...ver/appsmith-interfaces/src/main/java/com/appsmith/external/helpers/DataTypeStringUtils.java Show resolved Hide resolved


          Spelling error resolved.

9024bb6

sumitsum reviewed

View reviewed changes

...ver/appsmith-interfaces/src/main/java/com/appsmith/external/helpers/DataTypeStringUtils.java Show resolved Hide resolved

sumitsum reviewed

View reviewed changes

app/server/appsmith-plugins/restApiPlugin/src/main/java/com/external/plugins/RestApiPlugin.java Outdated Show resolved Hide resolved

sumitsum reviewed

View reviewed changes

...ver/appsmith-plugins/restApiPlugin/src/test/java/com/external/plugins/RestApiPluginTest.java Outdated Show resolved Hide resolved


          Incorporated review comments.

709da6c

trishaanand requested a review from sumitsum

March 11, 2021 06:51

sumitsum previously approved these changes

View reviewed changes


          Catching JSON Parse exception in http call.

0f3a501

trishaanand dismissed sumitsum’s stale review via

0f3a501

March 11, 2021 07:54

trishaanand requested a review from sumitsum

March 11, 2021 07:55

sumitsum approved these changes

View reviewed changes

trishaanand merged commit 9f63bfa into release

trishaanand deleted the feature/json-intelligent-substitution branch

March 11, 2021 08:40

sondermanish pushed a commit that referenced this pull request


          chore: add git support in convert to module flow (#3474)

a5b73ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet