Skip to content

Conversation

ram-primathon
Copy link
Contributor

Description

add ads multi select dropdown in propertypane

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ram-primathon ram-primathon changed the base branch from release to feature/property-pane-renovate February 26, 2021 06:40
@@ -22,12 +22,12 @@ type DropdownProps = CommonComponentProps & {
optionWidth?: string;
};

const DropdownContainer = styled.div<{ width?: string }>`
export const DropdownContainer = styled.div<{ width?: string }>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont export. Just copy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

});
this.updateProperty(this.props.propertyName, optionValues);
onItemSelect = (value: string[]): void => {
const isStarPresent = this.props.propertyValue.includes("*");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a new entry in dropdown option called selectsAll

@ram-primathon ram-primathon force-pushed the feature/property-pane-renovate-multi-dropdown branch from f988686 to df7e7a0 Compare February 26, 2021 09:42
@ram-primathon ram-primathon force-pushed the feature/property-pane-renovate-multi-dropdown branch from df7e7a0 to dc4dfbd Compare February 28, 2021 11:51
@hetunandu hetunandu merged commit d6417f6 into feature/property-pane-renovate Mar 1, 2021
@hetunandu hetunandu deleted the feature/property-pane-renovate-multi-dropdown branch March 1, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants