Fix issue while deleting a tab from explorer #3218
Conversation
| @@ -431,6 +432,23 @@ export function* deleteSaga(deleteAction: ReduxAction<WidgetDelete>) { | |||
| // SPECIAL HANDLING FOR TABS IN A TABS WIDGET | |||
| if (parent.type === WidgetTypes.TABS_WIDGET && widget.tabName) { | |||
| widgetName = widget.tabName; | |||
| // Deleting a tab from the explorer doesn't remove the same | |||
There was a problem hiding this comment.
Can we ensure that we don't leak abstractions here? Technically, the WidgetOperationSaga should be agnostic to the widget being deleted. Since the tab widget has special handling, we should have a function called deleteWidget in the BaseWidget class with an empty implementation. If any widget requires a special handling, the specific widget should override it's implementation of the delete function to fire the specific event.
There was a problem hiding this comment.
I am not sure how would that work for deleting a widget from outside the widget context, in this case from the entity explorer.
There was a problem hiding this comment.
@riodeuno is there a good solution here?
There was a problem hiding this comment.
@mohanarpit spoke to @riodeuno and since there is no good solution here and it needs some fundamental rearchitecting, we're merging this in
Description
Deleting from the explorer doesn't update the widgets
tabproperty. So doing the same as a special case for tabs in a tab widget in the delete widget saga.Fixes #2885
Type of change
How Has This Been Tested?
Manually
Checklist: