Mitigate misuse of Swift's pointer conversion feature #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milseman
reviewed
Apr 8, 2022
milseman
approved these changes
Apr 8, 2022
Contributor
milseman
left a comment
milseman
left a comment
There was a problem hiding this comment.
Put doc comments and some cleanup, otherwise LGTM
glessard
commented
Apr 8, 2022
glessard
force-pushed
the
glessard/rdar91436410
branch
2 times, most recently
from
6a3f211 to
d8b64ad
Compare
Contributor
Author
|
@swift-ci please test |
glessard
force-pushed
the
glessard/rdar91436410
branch
from
d8b64ad to
a63ef99
Compare
Contributor
Author
|
@swift-ci please test |
glessard
force-pushed
the
glessard/rdar91436410
branch
from
a63ef99 to
94ca9f3
Compare
Contributor
Author
|
@swift-ci please test |
lorentey
approved these changes
Jun 3, 2022
Member
lorentey
left a comment
lorentey
left a comment
There was a problem hiding this comment.
Shame we need to add all these overloads -- can't wait to have a language-level solution.
lorentey
force-pushed
the
glessard/rdar91436410
branch
from
94ca9f3 to
3a82bc8
Compare
glessard
force-pushed
the
glessard/rdar91436410
branch
from
10257a8 to
3920df7
Compare
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work done in swiftlang/swift#42002, addressing the exact same issues.
The family of
String(andFilePath) initializers that convert from C strings (null-terminated byte buffers) can be called with Swift arrays, which are converted toUnsafePointerarguments for C interoperability. However, when the array passed in to them violates the C string precondition of containing a zero byte, this can result in a buffer overflow.This PR overloads every such initializer with a version for
[CodeUnit]andinout CodeUnit, enforcing the null-terminated precondition. An overload for String is also added. The String overload may appear strictly useless, but it behaves differently than a direct copy when the source string contains an embedded null.Addresses rdar://91436410.