Skip to content

Conversation

@glessard
Copy link
Contributor

@glessard glessard commented Apr 7, 2022

Eliminates all uses of assumingMemoryBound in favor of temporary rebinding, using memory binding API for Swift <5.7. The end result is more memory-safe.

@glessard
Copy link
Contributor Author

glessard commented Apr 8, 2022

@swift-ci please test

@glessard glessard requested a review from milseman April 8, 2022 00:03
@glessard glessard force-pushed the glessard/binding-fixes branch from 79e3737 to f3ef70b Compare May 5, 2022 00:18
@glessard
Copy link
Contributor Author

glessard commented May 5, 2022

@swift-ci please test

@milseman milseman requested a review from lorentey May 5, 2022 14:59
@glessard glessard force-pushed the glessard/binding-fixes branch from f3ef70b to 64ed41a Compare May 11, 2022 22:06
@glessard glessard changed the title [test] rebind byte types safely Rebind byte types safely May 11, 2022
@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard glessard force-pushed the glessard/binding-fixes branch from 64ed41a to bf1e299 Compare May 16, 2022 19:26
@glessard
Copy link
Contributor Author

@swift-ci please test

- this doesn’t use the new memory binding API.
@glessard glessard force-pushed the glessard/binding-fixes branch from bf1e299 to 914c782 Compare May 28, 2022 00:09
@glessard
Copy link
Contributor Author

@swift-ci please test

@lorentey lorentey merged commit 5ba9e8f into main Jun 3, 2022
@lorentey lorentey deleted the glessard/binding-fixes branch June 3, 2022 22:16
etcwilde pushed a commit to etcwilde/swift-system that referenced this pull request May 13, 2025
* [benchmark] Reorganize C++/Foundation benchmarks into separate files

* [benchmark] Add reference benchmarks for std::vector<bool> and CFBitVector

* Fix thinko breaking non-Darwin builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants