build: install CSystem into the system #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSystem is a leaky library dependency from System and must be distributed. Install the files and make the dependency public so that it is emitted into the clients.
Collaborator
Author
milseman
reviewed
Dec 2, 2021
| Internals/Syscalls.swift | ||
| Internals/WindowsSyscallAdapters.swift) | ||
| target_link_libraries(SystemPackage PRIVATE | ||
| target_link_libraries(SystemPackage PUBLIC |
Contributor
There was a problem hiding this comment.
Just for my own education, what does this do?
Collaborator
Author
There was a problem hiding this comment.
This means that any user of SystemPackage will now transitively link against CSystem, which in this case propagates the include directives for the module definition (as it is an interface library). Because SystemPackage publicly imports CSystem and forwards certain items as @_emitIntoClient, we need to ensure that all clients of SystemPackage can see CSystem.
milseman
approved these changes
Dec 2, 2021
tomerd
approved these changes
Dec 2, 2021
Member
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSystem is a leaky library dependency from System and must be
distributed. Install the files and make the dependency public so that
it is emitted into the clients.