Fix IORing release build #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrflat
requested review from
Catfish-Man
and removed request for
glessard,
lorentey and
milseman
Contributor
Author
|
@swift-ci please test |
Catfish-Man
approved these changes
Jul 28, 2025
Member
Catfish-Man
left a comment
Catfish-Man
left a comment
There was a problem hiding this comment.
Seems fine to me. As you can see from the previous code there's been a bunch of juggling stuff to deal with compiler issues around initialization here.
glessard
approved these changes
Jul 28, 2025
|
Thanks! |
Contributor
|
@vsarunas I believe there's another fix incoming that we will want in a 1.6.1 tag. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute
submissionRingandcompletionRingbefore initializing all properties in one go to prevent a compiler error in release mode.Verified on a Swift 6.2 Ubuntu 22.04 image (swift-6.2-DEVELOPMENT-SNAPSHOT-2025-07-26-a) that System now builds in release mode (previously failed with the error shown in the issue).
Resolves #237