[Windows] Use GetTempPathW in _getTemporaryDirectory for better compatibility #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtyxtyx
requested review from
glessard,
lorentey and
milseman
as code owners
Contributor
|
@swift-ci please test |
glessard
approved these changes
Jan 29, 2025
This was referenced Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetTempPath2W function used by swift-system is only available on Windows 10 build 20348 and later systems. This PR replaces GetTempPath2W with the more compatible GetTempPathW, similar to what is done in swift-corelibs-foundation and swift-foundation.