Skip to content

CSystem: Set build and install interfaces on included headers #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glessard merged 1 commit into from
Jan 28, 2025
Merged

CSystem: Set build and install interfaces on included headers #209

glessard merged 1 commit into from
Jan 28, 2025

Conversation

@ADKaster
Copy link
Contributor

@ADKaster ADKaster commented Nov 21, 2024

This prevents a CMake error when including the project via FetchContent:

CMake Error in Build/release/_deps/swiftsystem-src/Sources/System/CMakeLists.txt:
  Target "CSystem" contains relative path in its
  INTERFACE_INCLUDE_DIRECTORIES:

    "include"

@glessard
Copy link
Contributor

glessard commented Nov 22, 2024

@swift-ci please test

@glessard glessard merged commit f27874d into apple:main Jan 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glessard glessard glessard approved these changes

@lorentey lorentey Awaiting requested review from lorentey lorentey is a code owner

@milseman milseman Awaiting requested review from milseman milseman is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ADKaster @glessard