-
Notifications
You must be signed in to change notification settings - Fork 159
Fix building specific Swift files in swift-clang with MSVC #45
Conversation
@@ -180,7 +184,7 @@ static void ProcessAPINotes(Sema &S, Decl *D, | |||
return UnavailableAttr::CreateImplicit(S.Context, | |||
CopyString(S.Context, | |||
info.UnavailableMsg)); | |||
}); | |||
}, getAttrIterator<UnavailableAttr>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I still think this would be handled better by overloading handleAPINotedAttribute
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't be sorry. I didn't understand what you meant, thought that was what you wanted.
You're right - I've updated the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't get pushed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well just my luck, git has it in for me
For reference, I've opened https://connect.microsoft.com/VisualStudio/feedback/details/3112067/msvc-fails-to-compile-code-that-compiles-in-clang-and-gcc to discuss MSVC's failings in the area of lambdas with generic parameters implicitly converting into another object inside a default parameter of a generic method. That is a mouthful! |
@swift-ci Please test |
@swift-ci Please test |
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@286525 91177308-0d34-0410-b5e6-96231b3b80d8
Hey, could you retrigger the CI - Clang had a syntax error that MSVC ignored |
Ah, will do. @swift-ci Please test |
Hey, @shahmishal, looks like we need the SHA-checking on the Clang bots too. |
@jrose-apple Thanks will update the PR jobs. |
Re-running anyway because the failures were unrelated. @swift-ci Please test |
Linux failure seems unrelated - lldb compile errors. Could you trigger the Linux tests (I don't have permission) |
@swift-ci Please test Linux platform |
Ah, @shahmishal, until the swift-3.1-branch of Swift and LLDB stabilizes, we should probably continue testing LLVM/Clang PRs against their master branches. |
I'm going to merge this anyway in the meantime. We got past compiling Swift on Linux, and these should not cause any functional changes. |
Previous PR #44 was nuked by GitHub
Commit 1:
Commit 2:
MSVC implodes compiling Clang, owing to the definition of llvm::None:
https://connect.microsoft.com/VisualStudio/feedback/details/3111599/
It throws the following strange, obfuscated error:
The fix is to give MSVC some more information. However, it still complains if we use
llvm::None
, so we have to usellvm::NoneType::None
. I assume the problem is that MSVC gets horribly confused at this line:const NoneType None = None;
Commit 3
/cc @DougGregor (this time, these files are swift-specific and no upstream version exists in Clang)
@hyp @jrose-apple