Skip to content

Update Suffix.swift #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Suffix.swift #186

wants to merge 1 commit into from

Conversation

mattyoung
Copy link
Contributor

Change endOfPrefix(while:) and startOfSuffix(while:) from internal to public

These two functions are generally useful so they should be public instead of internal
See https://forums.swift.org/t/should-there-be-bidirectionalcollection-droplast-while/48059/14
and https://forums.swift.org/t/endofprefix-while-and-startofsuffix-while-should-be-public-instead-of-internal/56855

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

Change `endOfPrefix(while:)` and `startOfSuffix(while:)` from internal to public
@lucianopa-msft
Copy link

Since we are making those public, couple of points are think are worth mention:

  • We probably need to add this to Changelog.md
  • We also may need a Guide the same way we have for all other algorithms here. See Guides for reference.
  • Add entry to the Readme.md
  • Verify if we have tests for those methods? I believe we test that indirectly through the public methods that use them internally, but not sure we have tests for them specifically (probably have, but maybe it is worth check)

@natecook1000
Copy link
Member

Landing this change in #211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants