Add --max-concurrent-downloads flag for parallel layer downloads #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmk142789
approved these changes
Oct 6, 2025
jglogan
reviewed
Oct 7, 2025
dcantah
reviewed
Oct 10, 2025
dcantah
reviewed
Oct 10, 2025
sbhavani
force-pushed
the
feature/parallel-layer-downloads
branch
from
c843892 to
cc15745
Compare
sbhavani
force-pushed
the
feature/parallel-layer-downloads
branch
from
cc15745 to
26ebe63
Compare
Implements concurrent layer downloads to improve image pull performance by fetching multiple layers simultaneously instead of sequentially.
sbhavani
force-pushed
the
feature/parallel-layer-downloads
branch
from
26ebe63 to
53e6c45
Compare
Contributor
Author
|
@dcantah anything else needed to merge this? |
Member
|
@sbhavani Yes. We need a tag of Containerization that has the changes. I'm making some changes over there but should have a tag out within the next day or so and then we can bump to this. We should not have our dependency on Containerization be to a branch, and especially not main 😄 |
Contributor
Author
no problem! I'll take a look and make the changes |
dkovba
requested changes
Nov 14, 2025
dkovba
reviewed
Nov 14, 2025
dkovba
reviewed
Nov 14, 2025
sbhavani
force-pushed
the
feature/parallel-layer-downloads
branch
from
e02e2ff to
21ac59f
Compare
dkovba
requested changes
Nov 19, 2025
Contributor
dkovba
left a comment
dkovba
left a comment
There was a problem hiding this comment.
Please run make fmt to pass the PR checks.
dkovba
reviewed
Nov 19, 2025
Sources/ContainerClient/Flags.swift
Outdated
| @Option(name: .long, help: ArgumentHelp("Progress type (format: none|ansi)", valueName: "type")) | ||
| public var progress: ProgressType = .ansi | ||
|
|
||
| @Option(name: .long, help: "Maximum number of concurrent layer downloads (default: 3)") |
Contributor
There was a problem hiding this comment.
@adityaramani Should we use the word "layer" or "blob" here?
Contributor
There was a problem hiding this comment.
Use just "concurrent downloads"
dkovba
reviewed
Dec 4, 2025
Contributor
dkovba
left a comment
dkovba
left a comment
There was a problem hiding this comment.
Please fix merge conflicts.
Resolved conflicts in: - Package.resolved: Updated to containerization 0.16.0 and new dependency hashes - ClientImage.swift: Preserved maxConcurrentDownloads parameter in fetch() method while adding new calculateDiskUsage() method from upstream - TestCLIImages.swift: Kept both maxConcurrentDownloads tests and new testImageSaveAndLoadStdinStdout test 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Removed duplicate declaration of set(key:value:) with Int64 parameter that was causing build failure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
dkovba
reviewed
Dec 4, 2025
Sources/Services/ContainerImagesService/Client/ImageServiceXPCKeys.swift
Outdated
Show resolved
Hide resolved
jglogan
requested changes
Dec 6, 2025
| reference: String, platform: Platform? = nil, scheme: RequestScheme = .auto, progressUpdate: ProgressUpdateHandler? = nil, maxConcurrentDownloads: Int = 3 | ||
| ) async throws -> ClientImage { | ||
| guard maxConcurrentDownloads > 0 else { | ||
| throw ContainerizationError(.invalidArgument, message: "--max-concurrent-downloads must be greater than 0, got \(maxConcurrentDownloads)") |
Contributor
There was a problem hiding this comment.
We shouldn't refer to command line arguments inside the client.
Should read "maximum number of concurrent downloads must be..."
Sources/ContainerClient/Flags.swift
Outdated
| @Option(name: .long, help: ArgumentHelp("Progress type (format: none|ansi)", valueName: "type")) | ||
| public var progress: ProgressType = .ansi | ||
|
|
||
| @Option(name: .long, help: "Maximum number of concurrent layer downloads (default: 3)") |
Contributor
There was a problem hiding this comment.
Use just "concurrent downloads"
|
|
||
| #expect(status != 0, "Expected command to fail with maxConcurrentDownloads=0") | ||
| #expect( | ||
| error.contains("--max-concurrent-downloads must be greater than 0"), |
jglogan
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--max-concurrent-downloadsflag tocontainer image pullfor configurable concurrent layer downloads.Fixes #715
Depends on apple/containerization#311
Usage:
Changes:
Performance: ~1.2-1.3x faster pulls for multi-layer images with higher concurrency
Tests: Included standalone tests verify concurrency behavior and parameter flow