Fix support for Node 0.10 which was broken by #3 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think it's fair to say most people would be just using 4.3 going forward, for that reason I don't think it's necessary |
Author
|
Possibly though it unexpectedly broke all of my existing apex functions when I updated this module and I spent awhile pulling my hair out trying to figure out why the requests were timing out. Didn't seem too complex to make it backwards compatible. Anyway, if you don't want to accept this PR I'll open another that at least updates the README to inform people that if they're using Node 0.10 on Lambda they need to use 1.x and not 2.x |
Member
|
Ah, yea we should have had a changelog note for that, I'll add something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it was nice that #3 added support for Node 4.3 on Lambda, it totally broke Node 0.10 on Lambda causing requests with errors to time out.
This PR fixes it so this module works with both.