Skip to content

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Apr 9, 2025

For all changes

  • Is there a issue associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with #XXXX where XXXX is the issue number you are trying to resolve?

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

  • Is the code properly formatted with mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false?

For code changes

  • Have you ensured that the full suite of tests is executed via mvn clean verify?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file?

Note

Fixes the comments raised during last release.

@rzo1 rzo1 added this to the 3.4.0 milestone Apr 9, 2025
@rzo1 rzo1 requested review from tballison and mvolikas April 9, 2025 14:31
@rzo1 rzo1 self-assigned this Apr 9, 2025
@jnioche jnioche merged commit a27e2a4 into main Apr 9, 2025
2 checks passed
@rzo1 rzo1 deleted the fix-readme branch June 16, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants