[SPARK-52238][TESTS][FOLLOW-UP] Fix test failure in classic-only envs #51094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
force-pushed
the
fix_pp_no_grpc
branch
from
1490b41 to
342a9cf
Compare
HyukjinKwon
approved these changes
Jun 5, 2025
xinrong-meng
approved these changes
Jun 6, 2025
Member
|
LGTM, would you retrigger the test? |
zhengruifeng
force-pushed
the
fix_pp_no_grpc
branch
from
425d6ae to
03570d8
Compare
Contributor
Author
|
thanks, merged to master |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
### What changes were proposed in this pull request? fix import error in classic-only envs: - pypy3.10 - python3.11-classic-only - python3.13-nogil ### Why are the changes needed? https://github.com/apache/spark/actions/runs/15430761771/job/43428094456 ``` Starting test(python3.11): pyspark.pipelines.tests.test_block_connect_access (temp output: /__w/spark/spark/python/target/e57e05b9-80f9-4149-9a9c-898cf497bd80/python3.11__pyspark.pipelines.tests.test_block_connect_access__wv66e6_5.log) Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/__w/spark/spark/python/pyspark/pipelines/tests/test_block_connect_access.py", line 21, in <module> from pyspark.pipelines.block_connect_access import block_spark_connect_execution_and_analysis File "/__w/spark/spark/python/pyspark/pipelines/block_connect_access.py", line 21, in <module> from pyspark.sql.connect.proto.base_pb2_grpc import SparkConnectServiceStub File "/__w/spark/spark/python/pyspark/sql/connect/proto/__init__.py", line 18, in <module> from pyspark.sql.connect.proto.base_pb2_grpc import * File "/__w/spark/spark/python/pyspark/sql/connect/proto/base_pb2_grpc.py", line 19, in <module> import grpc ModuleNotFoundError: No module named 'grpc' ``` ### Does this PR introduce _any_ user-facing change? no, test-only ### How was this patch tested? PR builder with ``` default: '{"PYSPARK_IMAGE_TO_TEST": "python-311-classic-only", "PYTHON_TO_TEST": "python3.11"}' ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#51094 from zhengruifeng/fix_pp_no_grpc. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix import error in classic-only envs:
Why are the changes needed?
https://github.com/apache/spark/actions/runs/15430761771/job/43428094456
Does this PR introduce any user-facing change?
no, test-only
How was this patch tested?
PR builder with
Was this patch authored or co-authored using generative AI tooling?
No