[SPARK-53430] Prevent unintended JSON serialization with @JsonIgnore #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request? This PR adds @JsonIgnore to helper methods in API to avoid unintentional serialization. ### Why are the changes needed? Some non-field heler methods in our API POJO classes can be unintentionally serialized as Jackson treat them as getters. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CIs ### Was this patch authored or co-authored using generative AI tooling? No
peter-toth
approved these changes
Sep 2, 2025
peter-toth
changed the title
|
Thanks @jiangzho for the fix. Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds @JsonIgnore to helper methods in API to avoid unintentional serialization.
Why are the changes needed?
Some non-field heler methods in our API POJO classes can be unintentionally serialized as Jackson treat them as getters.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CIs
Was this patch authored or co-authored using generative AI tooling?
No