ci: run lua test cases with luajit #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since lua-cjson 2.1.0-1 may fail to install, ref openresty/lua-cjson#21, so use lua-cjson2, ref: leafo/lapis#539 (comment) Signed-off-by: tzssangglass <[email protected]>
|
Is this trying to help #93? |
Signed-off-by: tzssangglass <[email protected]>
yes |
Signed-off-by: tzssangglass <[email protected]>
Signed-off-by: tzssangglass <[email protected]>
|
If you are going to change CI process, you need to change the doc here, https://github.com/apache/skywalking-nginx-lua#local-development-and-unit-tests |
Signed-off-by: tzssangglass <[email protected]>
Thanks for the reminder, I will change the doc after the CI pass. |
Signed-off-by: tzssangglass <[email protected]>
Signed-off-by: tzssangglass <[email protected]>
|
great. |
alonelaval
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since lua-cjson 2.1.0-1 may fail to install, ref
openresty/lua-cjson#21, so use lua-cjson2,
ref: leafo/lapis#539 (comment)
Signed-off-by: tzssangglass [email protected]