Skip to content

Fix gRPC plugin not working for server side in some case #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2023
Merged

Fix gRPC plugin not working for server side in some case #457

merged 2 commits into from
Feb 15, 2023

Conversation

devkanro
Copy link
Contributor

@devkanro devkanro commented Feb 14, 2023 •
edited
Loading

What's Changed?

  1. Modify the Instrumentation point to the build function for server builder, it can make sure the tracing interceptor has been added as latest interceptor which been called as first one, and fix the server interceptor not working with fallbackHandler or BindableService.
  2. Change the span creating timing from call ready to new call and store the snapshot to call context, it will make the spans created during the entire call process be associated

TODO

  • Fix the test

@devkanro
Copy link
Contributor Author

@wu-sheng This PR is ready for review

@wu-sheng wu-sheng added this to the 8.15.0 milestone Feb 15, 2023
@wu-sheng wu-sheng added the enhancement New feature or request label Feb 15, 2023
@wu-sheng wu-sheng merged commit 6b35f06 into apache:main Feb 15, 2023
@sw1136562366 sw1136562366 mentioned this pull request Apr 19, 2023
Merged
@h0cheung h0cheung mentioned this pull request Dec 26, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request plugin
Projects
None yet
Milestone
8.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@devkanro @wu-sheng