Remove TLS statement in BouncyCastle intro. #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
reviewed
Nov 15, 2024
Member
|
Btw. This PR made changes to Bouncy Castle usage apache/pulsar#23122. I was one of the committers to approve that PR. It looks like Bouncy Castle won't ever be used in typical cases when running on OpenJDK or Oracle JDK where SunJCE is available. @codelipenghui Is that something that we should make configurable instead? |
Co-authored-by: Lari Hotari <[email protected]>
Member
|
@lhotari - is this ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Contribution Checklist
Pulsar does not implement bouncy castle jsse. There is no dependency on bc jsse in pulsar.
Correcting the doc.