Skip to content

[Do Not Merge] Test PR to check if pre-commit check works fine once codebase has no spotless issues #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NihalJain
Copy link
Contributor

@NihalJain NihalJain commented Apr 16, 2025

@NihalJain
Copy link
Contributor Author

Some how 1st commit's patch doesnot apply to master. Need to check!

@NihalJain NihalJain force-pushed the PHOENIX-7442_plus_PHOENIX-7443 branch from 74179cc to 5a1b8b2 Compare April 16, 2025 11:25
@NihalJain
Copy link
Contributor Author

NihalJain commented Apr 16, 2025

Some how 1st commit's patch doesnot apply to master. Need to check!

Code is on top of latest master, not sure why patch fails to apply with error:

16:56:40  | Vote |    Subsystem |  Runtime   | Comment
16:56:40  ============================================================================
16:56:40  |   0  |      reexec  |   0m  0s   | Docker mode activated. 
16:56:40  |  -1  |       patch  |   0m  6s   | 
16:56:40  |      |              |            | https://github.com/apache/phoenix/pull/2120
16:56:40  |      |              |            | does not apply to master. Rebase required?
16:56:40  |      |              |            | Wrong Branch? See
16:56:40  |      |              |            | https://yetus.apache.org/documentation/in-pr
16:56:40  |      |              |            | ogress/precommit-patchnames for help.
16:56:40  

Any idea @stoty ?

@NihalJain NihalJain changed the title [Do Not Merge] Test PR to check if pre-commit check works fine once code base have no spotless issues [Do Not Merge] Test PR to check if pre-commit check works fine once codebase has no spotless issues Apr 16, 2025
@stoty
Copy link
Contributor

stoty commented Apr 16, 2025

I think yetus simply has problems with very large patches @NihalJain .

@NihalJain
Copy link
Contributor Author

I think yetus simply has problems with very large patches @NihalJain .

Ok in that case we can't even have a success build for #2024 since it is huge

@NihalJain NihalJain force-pushed the PHOENIX-7442_plus_PHOENIX-7443 branch from 5a1b8b2 to 52b5020 Compare April 16, 2025 12:57
@NihalJain NihalJain force-pushed the PHOENIX-7442_plus_PHOENIX-7443 branch from 52b5020 to b874306 Compare April 16, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants