This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[clojure-package] fix docstrings in normal.clj
#14295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for your contribution @Chouffe. I look forward to reviewing it shortly 😸 |
gigasquid
reviewed
Mar 1, 2019
Member
gigasquid
left a comment
gigasquid
left a comment
There was a problem hiding this comment.
Thanks for the improvements! Looks great 💯
| `ctx`: Context of output ndarray, will use default context if not specified. | ||
| `out`: Output place holder} | ||
| returns: The result ndarray with generated result. | ||
| Ex: |
Member
There was a problem hiding this comment.
Examples in the docstring are very nice 💯
| This means if you set the same seed, the random number sequence | ||
| generated from GPU0 can be different from CPU." | ||
| generated from GPU0 can be different from CPU. | ||
| Ex: |
gigasquid
approved these changes
Mar 1, 2019
Member
|
It is good to go once the CI tests pass |
Contributor
Author
|
The main issue was in the docstring for |
Contributor
Author
|
Not sure why CI has not run? |
Member
|
@mxnet-label-bot add [pr-awaiting-merge, Clojure] |
marcoabreu
added
Clojure
pr-awaiting-merge
Member
|
@Chouffe would you mind pushing an empty commit or something to retrigger the CI? I think it might be fixed now |
* Fixed documentation string in `normal` function * Added spec to catch `high` < `low` in `uniform` * Added spec to catch `scale` <= 0 in `normal` * Added unit tests
Contributor
Author
|
I just rebased on upstream master and pushed again :) |
Contributor
Author
|
It seems to be green @gigasquid :-) |
Member
|
Yay! thanks |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* Fixed documentation string in `normal` function * Added spec to catch `high` < `low` in `uniform` * Added spec to catch `scale` <= 0 in `normal` * Added unit tests
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Fixed documentation string in `normal` function * Added spec to catch `high` < `low` in `uniform` * Added spec to catch `scale` <= 0 in `normal` * Added unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
high<lowinuniformscale<= 0 innormalChecklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments