-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[CI] Prevent timeouts when rebuilding containers with docker. #13818
Conversation
|
@mxnet-label-bot add [pr-awaiting-review, Scala] |
lanking520
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, could you please point to some PRs that have this issue?
|
I restarted 4 PRs because of this issue |
aaronmarkham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the website publish job need this increase too?
https://github.com/apache/incubator-mxnet/blob/master/docs/Jenkinsfile#L24
|
@aaronmarkham yes, could we move that into the ci/ folder for consistency? it's easy to miss if we have scripts and infrastructure in the docs folder. |
|
Could we hold on with the merge please. I'm not really sure whether this fixes the problem or works around another regression |
When I first put this together @marcoabreu and I discussed that, but I can't remember why it was better to have it in docs. Maybe that's changed? Marco, do you remember why? If we need to leave it there we could add some notes to the CI readme so it doesn't get overlooked. |
While we hold on CI is having time outs. It took me quite a bit to get the PR to pass CI because of the timeouts (had to manually rebuild the cache). What steps are you taking to understand if it fixes the problem? What makes you think my fix doesn't address the problem? If CI is having failures we can't merge PRs that fix CI because of protected master. |
Increase timeout from 120 to 180 for pipelines
lanking520
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small concern there. Otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
|
Responded, would appreciate if this would be merged to prevent CI failures. |
lebeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be great to merge
…#13818) * Prevent timeouts when rebuilding containers with docker. Increase timeout from 120 to 180 for pipelines * Increase docker cache timeout * Increase timeout also for docs * limit parallel builds to 10

Increase timeout from 120 to 180 for pipelines
Increase timeout for docker pull as we get timeout when rebuilding the docker cache:
http://jenkins.mxnet-ci.amazon-ml.com/job/restricted-docker-cache-refresh/job/master/1190/console
Limit parallel builds to 10
Description
Mitigation for failing CI
fixes #13817
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.