[SUREFIRE-2172] StringUtils: yet more of them

[jira-importer]

Elliotte Rusty Harold opened SUREFIRE-2172 and commented

This project contains not one, not two, but three different StringUtils classes that duplicate functionality in the JDK and elsewhere. One or two of them imght be built by shading other classes. They're even sometimes both imported in the same classes such as LegacyPojoStackTraceWriter:

import org.apache.maven.surefire.api.util.internal.StringUtils;

import static org.apache.maven.surefire.shared.utils.StringUtils.isNotEmpty;

Figure out what to do about this.

---

Remote Links:

• GitHub Pull Request #768
  

[jira-importer]

Michael Osipov commented

So we are talking about:

$ grep -r --include='*.java' StringUtils . | grep -v -e org.apache.maven.surefire.shared -v -e org.apache.maven.surefire.api.util.internal.StringUtils | grep import
./surefire-its/src/test/java/org/apache/maven/surefire/its/JUnit47RedirectOutputIT.java:import org.apache.commons.lang3.StringUtils;
./surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java:import static org.apache.maven.shared.utils.StringUtils.isNotBlank;
./surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportParser.java:import static org.apache.maven.shared.utils.StringUtils.split;
./surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:import static org.apache.maven.shared.utils.StringUtils.isBlank;

and at the end it is only:

$ grep -r --include='*.java' StringUtils . | grep -v -e org.apache.maven.surefire.shared -v -e org.apache.maven.surefire.api.util.internal.StringUtils | grep import
./surefire-its/src/test/java/org/apache/maven/surefire/its/JUnit47RedirectOutputIT.java:import org.apache.commons.lang3.StringUtils;

Right?

[jira-importer]

Elliotte Rusty Harold commented

No, I think there's more. E.g. in surefire-api/src/main/java/org/apache/maven/surefire/api/report/LegacyPojoStackTraceWriter.java

I'm not sure where all these are coming from yet.