[SUREFIRE-2037] Allow for surefire-junit-platform's TestMethodFilter to support custom TestSources

[jira-importer]

Krzysztof Sierszeń opened SUREFIRE-2037 and commented

Since JUnit 5 allows for custom {}TestSource{}s to be configured, TestMethodFilter could provide a way for those sources to be recognized and filterable. This way, custom method sources will enjoy the same filtering capabilities that method sources do. 

For now, this change specifically targets ArchUnit's FieldSource, and I'm planning to use the solution provided to solve the following issue. 

---

Affects: 3.0.0-M5

Remote Links:

• GitHub Pull Request #487
  
• Related issue
  

[jira-importer]

Krzysztof Sierszeń commented

See #487

[jira-importer]

Tibor Digana commented

crizzis_dna
Pls describe very properly what you are aiming for in the JIRA in details.
Can you explain how the customer would implement the interface TestSelectorFactory you have introduced? What types of sources can be filtered and how they can be configured?

[jira-importer]

Krzysztof Sierszeń commented

tibordigana Please see the following comment

[jira-importer]

Tibor Digana commented

crizzis_dna
My problem is that we have opened SPI interface for TestSources but we did not implement it.
The surefire-junit-platform with classes and methods was the first step to introduce this provider into the world because that time there was 100% users with test classes.
If we want to continue with supporting more than classes, we have only one option to support the rest of TestSources in this project and not outside of the plugin or project - behind SPI. It is not realistic situation that the users will implement it by themselves. They do not have time to do it. They want to specify a new version of plugin in the POM or they use new version of Maven which has this version in default bindings and that's whole business. The main goal of the plugin is to execute the tests but it is not realistic to shift it to somewhere and make this basic functionality plugin-able again apart.
So yes, if we want to continue with multiple TestSources then we should implement them inside in this project and not outside. This should be our work.

[jira-importer]

Tibor Digana commented

The next big problem is that we have more and more code but I did not see integration tests without SPI, means with TestSource - field, directory, script, etc.
There must be unit tests. I have paid very big attention to cover this project with unit tests and we should continue with this attitude.