Skip to content

Conversation

@ppkarwasz
Copy link
Contributor

This change introduces a separate cache specifically for the verify-reproducibility workflow to ensure it does not reuse artifacts cached by other workflows. By isolating its cache, we ensure that reproducibility checks are based solely on artifacts built within the same workflow, improving the reliability and accuracy of the verification.

Closes #388

This change introduces a separate cache specifically for the verify-reproducibility workflow to ensure it does not reuse artifacts cached by other workflows.
By isolating its cache, we ensure that reproducibility checks are based solely on artifacts built within the same workflow, improving the reliability and accuracy of the verification.

Closes #388
@ppkarwasz ppkarwasz requested review from Copilot and vy June 7, 2025 06:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a dedicated cache for the verify-reproducibility workflow to prevent reuse of artifacts from other workflows, ensuring accurate reproducibility verification, and records this change in the project changelog.

  • Add a new changelog entry for issue #388.
  • Remove the default Maven cache from setup-java and add custom cache steps with a monthly key prefix in the reusable workflow.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/changelog/.12.x.x/verify_reproducibility-cache.xml New changelog entry for isolating the reproducibility cache
.github/workflows/verify-reproducibility-reusable.yaml Remove built-in Maven cache; compute a monthly cache key prefix and configure custom Maven caching
Comments suppressed due to low confidence (1)

.github/workflows/verify-reproducibility-reusable.yaml:74

  • [nitpick] The environment variable name 'CACHE_KEY' is very generic; consider renaming it to something more specific (e.g., 'VERIFY_REPRO_CACHE_KEY') to avoid potential collisions with other workflows.
date +"CACHE_KEY=verify-reproducibility-%Y-%m" >> $GITHUB_ENV

@ppkarwasz ppkarwasz merged commit 7b83a8c into main Jun 10, 2025
9 checks passed
@ppkarwasz ppkarwasz deleted the fix/verify-reproducibility-cache branch June 10, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent Reproducibility Verification Due to Shared Maven Cache

2 participants