Fix flaky test, ignore order of elements in list validation #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
vinishjail97
reviewed
Mar 6, 2025
Comment on lines
+139
to
140
| assertEqualsIgnoreOrder( | ||
| expectedPartitionToReplacedFileIds, replaceMetadata.getPartitionToReplacedFileIds()); |
Contributor
There was a problem hiding this comment.
This can be simplified to ?
assertEquals(new HashSet<>(expectedPartitionToReplacedFileIds), new HashSet<>(replaceMetadata.getPartitionToReplacedFileIds()))
Contributor
Author
There was a problem hiding this comment.
Hi @vinishjail97 . I didn't understand. Have you tried this change, does it compile?
expectedPartitionToReplacedFileIdsis aHashMapwhich cannnot be used to initialize aHashSet- The order mismatch happens in the
valuesof the HashMaps, where thevaluesareLists. The tests fails when the values in the lists are out of order. Please see the example in the bug report for reference.
Contributor
Author
There was a problem hiding this comment.
Also, could you please confirm that Hudi does not depend on the order of the files in the lists?
Contributor
There was a problem hiding this comment.
My bad didn't see it was Map<String, List<String>>, change LGTM.
Hudi does not depend on the order of the files in the lists?
Yes it does not depend on order.
vinishjail97
approved these changes
Mar 6, 2025
ashvina
deleted the
658-testbasefileupdatesextractor-convertdiff-is-flaky
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #658
This change fixes a test only. The test is currently comparing the equality of two lists, which would fail if the order of elements in the lists differ. Since the test is order insensitive, the right solution is to convert the lists to sets. Set equality is order independent.