Delta source: add record count for DataFile #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| public long getNumRecords(AddFile addFile) { |
Contributor
There was a problem hiding this comment.
Instead of parsing the stats twice, is there a way we can include this with the column stats output of getColumnStatsForFile? Maybe we can have some wrapper that wraps the count with the formatted stats?
Contributor
Author
There was a problem hiding this comment.
Sure, I created a wrapper called FileStats, which contains List<ColumnStat> and numRecords for per file.
the-other-tim-brown
approved these changes
Jan 31, 2025
Contributor
the-other-tim-brown
left a comment
the-other-tim-brown
left a comment
There was a problem hiding this comment.
LGTM! Can you squash down to a single commit for me? After that, I will merge the PR.
The change improved how to get the number of records from Delta source and fixed the edge case when columnStats list is empty, the number of records is 0. A wrapper called FileStats is added to wrap the list of ColumnStat and num of records per file.
emilie-wang
force-pushed
the
fix_delta_stats_count
branch
from
06f9578 to
cadc7d8
Compare
Contributor
Author
|
@the-other-tim-brown Thank you for the review and I have squashed down to 1 commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Read
What is the purpose of the pull request
Addresses #102
Brief change log
Verify this pull request
This change added tests and can be verified as follows: