-
Notifications
You must be signed in to change notification settings - Fork 3.3k
HBASE-28951 use unique name of temp recovered edits for each worker #7075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this could work. What if 'split to hfile' is enabled?
@@ -55,9 +55,14 @@ public AbstractRecoveredEditsOutputSink(WALSplitter walSplitter, | |||
/** Returns a writer that wraps a {@link WALProvider.Writer} and its Path. Caller should close. */ | |||
protected RecoveredEditsWriter createRecoveredEditsWriter(TableName tableName, byte[] region, | |||
long seqId) throws IOException { | |||
// If multiple worker are splitting a WAL at a same time, both should use unique file name to | |||
// avoid conflict | |||
long workerStartCode = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is startCode enough to make unique directory? Different region server could have same start code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I missed this point, this won't work.
To use the whole RS server name, I was worried about reaching the filename lenght limit. Do you also see this concern on it?
🎊 +1 overall
This message was automatically generated. |
No description provided.