FINERACT-2081: Fix Interest Payment Waiver reverse-replay transaction. #4284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somasorosdpc
force-pushed
the
FINERACT-2081/fix-interest-payment-waiver-reverse-replay-issue
branch
from
1478961 to
332b18a
Compare
galovics
requested changes
Jan 25, 2025
| import org.apache.fineract.integrationtests.common.ExternalEventConfigurationHelper; | ||
| import org.apache.fineract.integrationtests.common.Utils; | ||
| import org.junit.jupiter.api.Assertions; | ||
|
|
||
| @Slf4j | ||
| public final class ExternalEventHelper { | ||
| public final class ExternalEventHelper extends IntegrationTest { |
There was a problem hiding this comment.
Is there any tests i this class? If no, then let's not start inheriting from the base test class.
There was a problem hiding this comment.
I'm just following a pattern as many Helper class extends IntegrationTest to access to fineract() client. And the purpose here is to use less depricated ( marked for removal ) api on helpers.
… on transaction creation.
somasorosdpc
force-pushed
the
FINERACT-2081/fix-interest-payment-waiver-reverse-replay-issue
branch
from
332b18a to
ea07023
Compare
galovics
approved these changes
Jan 29, 2025
somasorosdpc
deleted the
FINERACT-2081/fix-interest-payment-waiver-reverse-replay-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Interest Payment Waiver reverse-replay transaction on transaction creation.
Also fixed Interest PAyment Waiver null external Id caused by reverse replay.
Created a specific Integration test case + refactor use less @depricated features from integration tests.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.