FINERACT-2104: Accrual Activity Reverse Replay Transaction #3963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somasorosdpc
force-pushed
the
FINERACT-2104/accrual_activity_posting_reverse_transaction_and_job
branch
5 times, most recently
from
86b0a08 to
11da875
Compare
adamsaghy
reviewed
Jul 10, 2024
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Show resolved
Hide resolved
adamsaghy
reviewed
Jul 10, 2024
...anaccount/domain/transactionprocessor/AbstractLoanRepaymentScheduleTransactionProcessor.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jul 10, 2024
| } | ||
| } | ||
| reprocessInstallments(disbursementDate, transactionsToBeProcessed, installments, currency); | ||
| return changedTransactionDetail; | ||
| } | ||
|
|
||
| private void recalculateAccrualActivityTransaction(ChangedTransactionDetail changedTransactionDetail, LoanTransaction loanTransaction, |
There was a problem hiding this comment.
This is okay for all the transaction processor but the AdvancedPaymentScheduleTransactionProcessor, there it has its own reprocessLoanTransactions logic, so you need to add the Accrual Activity explicitly.
Probably you can reuse recalculateAccrualActivityTransaction but maybe you need to change the visibility to be protected instead of private.
There was a problem hiding this comment.
will fix and include integration test case.
There was a problem hiding this comment.
For Advanced payment allocation processor, it might not work properly immediately hence the recalculation for interest bearing loan is in progress. You might need to create a non-interest bearing progressive loan to test it.
somasorosdpc
force-pushed
the
FINERACT-2104/accrual_activity_posting_reverse_transaction_and_job
branch
2 times, most recently
from
c41013e to
7b56d38
Compare
somasorosdpc
force-pushed
the
FINERACT-2104/accrual_activity_posting_reverse_transaction_and_job
branch
from
7b56d38 to
e8a9db4
Compare
adamsaghy
changed the title
somasorosdpc
deleted the
FINERACT-2104/accrual_activity_posting_reverse_transaction_and_job
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.