-
Notifications
You must be signed in to change notification settings - Fork 2.1k
FINERACT-2090: Refactor and cleanup Loan entity #3924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adamsaghy
merged 1 commit into
apache:develop
from
kjozsa:FINERACT-2090/cleanup-loan-entity
Jun 12, 2024
Merged
FINERACT-2090: Refactor and cleanup Loan entity #3924
adamsaghy
merged 1 commit into
apache:develop
from
kjozsa:FINERACT-2090/cleanup-loan-entity
Jun 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Jun 11, 2024
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jun 11, 2024
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Show resolved
Hide resolved
adamsaghy
reviewed
Jun 11, 2024
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jun 11, 2024
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jun 11, 2024
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jun 11, 2024
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jun 11, 2024
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jun 11, 2024
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Outdated
Show resolved
Hide resolved
ebe0eb5
to
7a58d49
Compare
7a58d49
to
976cef8
Compare
adamsaghy
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of a larger changeset, covered by the ticket FINERACT-2090, aiming to seriously improve the Loan module's code quality. These changes focus solely on cleaning up the Loan class, which was ~7000 lines long at the develop HEAD originally.
All changes are either of the following kinds:
Applying these changes helped to cut over 600 lines of code from this class alone, keeping the same functionality and seriously improving readability of the remaining parts.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
[X ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
[ X] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
[ X] Create/update unit or integration tests for verifying the changes made.
[ X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
[ X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
[ X] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.