Fix array_position on empty list
#16292
Open
+18
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blizzara
force-pushed
the
avo/array-position-empty-array
branch
from
6fec731 to
e0772b2
Compare
github-actions
bot
added
documentation
Blizzara
force-pushed
the
avo/array-position-empty-array
branch
from
e0772b2 to
a32363a
Compare
Blizzara
changed the title
alamb
changed the title
array_position on empty list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
array_positionwould fail if its input is an empty list.Rationale for this change
Empty list shouldn't be any different from any other list not containing the looked-for element.
What changes are included in this PR?
Fix the empty list case. Also document that return value is NULL if element is not found, and that the start-index is 1-based (since that was confusing me for a while).
Are these changes tested?
New SLT tests
Are there any user-facing changes?
Less crashing and more info in docs 😄