CASSJAVA-2 Fix TableMetadata.describe() when containing a vector column #1978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch by Stefan Miklosovic; reviewed by TBD for CASSJAVA-2
absurdfarce
reviewed
Nov 12, 2024
| @@ -60,7 +60,7 @@ public String getClassName() { | |||
| @NonNull | |||
| @Override | |||
| public String asCql(boolean includeFrozen, boolean pretty) { | |||
| return String.format("'%s(%d)'", getClassName(), getDimensions()); | |||
| return String.format("vector<%s, %d>", getElementType().asCql(true, false), getDimensions()); | |||
There was a problem hiding this comment.
This is already fixed in @SiyaoIsHiding 's PR for JAVA-3118. I like the addition of a unit test for it, however, so my inclination is to merge this PR and then have Jane update her PR to remove her change.
Thoughts?
There was a problem hiding this comment.
Got confirmation from @SiyaoIsHiding in separate communication that she's fine with tweaking the JAVA-3118 PR after this goes in... so we're all set to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch by Stefan Miklosovic; reviewed by TBD for CASSJAVA-2