Skip to content

ParDoLifecycleTest concurrency bug - callStateMap #36886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 1 commit into from
Nov 24, 2025
Merged

ParDoLifecycleTest concurrency bug - callStateMap #36886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoLifecycleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
Expand Down Expand Up @@ -293,7 +293,7 @@ public void testTeardownCalledAfterExceptionInFinishBundleStateful() {

@Before
public void setup() {
ExceptionThrowingFn.callStateMap = new HashMap<>();
ExceptionThrowingFn.callStateMap.clear();
ExceptionThrowingFn.exceptionWasThrown.set(false);
}

Expand Down Expand Up @@ -356,7 +356,7 @@ CallState finalState() {
}

private static class ExceptionThrowingFn<T> extends DoFn<T, T> {
static HashMap<Integer, DelayedCallStateTracker> callStateMap = new HashMap<>();
static Map<Integer, DelayedCallStateTracker> callStateMap = new ConcurrentHashMap<>();
// exception is not necessarily thrown on every instance. But we expect at least
// one during tests
static AtomicBoolean exceptionWasThrown = new AtomicBoolean(false);
Expand All @@ -373,7 +373,10 @@ private static void validate(CallState... requiredCallStates) {
Map<Integer, DelayedCallStateTracker> callStates;
synchronized (ExceptionThrowingFn.class) {
callStates =
(Map<Integer, DelayedCallStateTracker>) ExceptionThrowingFn.callStateMap.clone();
(Map<Integer, DelayedCallStateTracker>)
Collections.synchronizedMap(
ExceptionThrowingFn.callStateMap.entrySet().stream()
.collect(Collectors.toMap(e -> e.getKey(), e -> e.getValue())));
}
assertThat(callStates, is(not(anEmptyMap())));
// assert that callStateMap contains only TEARDOWN as a value. Note: We do not expect
Expand Down
Loading