Skip to content

Conversation

@tarun-google
Copy link
Contributor

Add temp_location to all Batch Write to big query examples and integration tests. Fixes #35198

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the reliability and correctness of BigQuery batch write operations across various examples and integration tests by explicitly defining a temporary storage location. This ensures that pipelines have a designated staging area for intermediate data, preventing potential issues related to temporary file management and resolving a reported bug.

Highlights

  • BigQuery Write Examples: Explicitly added "temp_location" configuration to several BigQuery write examples in YAML blueprints, including "gcs_text_to_bigquery", "jdbc_to_bigquery", "mysql_to_bigquery", "oracle_to_bigquery", "postgres_to_bigquery", and "spanner_to_bigquery".
  • ML Preprocessing Example: Included "temp_location" in the options for the "ml_preprocessing.yaml" example, ensuring proper temporary storage for ML-related pipelines.
  • BigQuery Integration Tests: Updated the "bigquery.yaml" extended test to include "project" and "temp_location" options for its BigQuery write operations, enhancing test reliability.
  • Issue Resolution: This change directly addresses and fixes the issue reported in The PostCommit YAML Xlang Direct job is flaky #35198, improving the robustness of BigQuery batch write operations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@tarun-google
Copy link
Contributor Author

Run Python PreCommit 3.12

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @jrmccluskey for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tarun-google
Copy link
Contributor Author

R: @Amar3tto

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Amar3tto Amar3tto self-requested a review October 1, 2025 05:27
@Amar3tto Amar3tto merged commit 7586658 into apache:master Oct 1, 2025
103 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit YAML Xlang Direct job is flaky

2 participants