Skip to content

Conversation

@tarun-google
Copy link
Contributor

@tarun-google tarun-google commented Sep 26, 2025

Fix for failing Bigquery integration tests post migration #36139
Fixed issue: #35198

  1. temp_location is not optional, its a requirement for Batch write operations after migration. This should not be an issue for customers. As temp_location is necessity to run workflows on DataflowRunner
  2. Realized there is a bug in integration_test.py. For options to get replaced by original values we have to use replace_recursive similar to pipeline variables in below line. We might not have caught it as options are optional for most of our cases.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves critical issues that were causing BigQuery batch write integration tests to fail following a recent migration. It addresses a newly introduced requirement for specifying a temp_location in BigQuery batch write operations and fixes a bug in the test runner where pipeline options were not being correctly processed with variable substitution.

Highlights

  • BigQuery Batch Write temp_location Requirement: Updated the enrichment.yaml test configuration to explicitly include project and temp_location options for BigQuery batch write operations, addressing a new requirement post-migration.
  • Integration Test Pipeline Options Bug Fix: Corrected a bug in integration_tests.py by applying replace_recursive to pipeline options, ensuring that variables within options are properly substituted during test execution, which was previously overlooked.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tarun-google
Copy link
Contributor Author

Run Python_ML PreCommit 3.12

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@tarun-google
Copy link
Contributor Author

Run Python_ML PreCommit 3.12

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @tvalentyn for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Amar3tto Amar3tto merged commit 9cd994e into apache:master Sep 28, 2025
119 of 124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants