-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[GSoC 25][Blog Post]: Beam ML Vector DB/Feature Store Project #36301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC 25][Blog Post]: Beam ML Vector DB/Feature Store Project #36301
Conversation
|
/gemini review |
Summary of ChangesHello @mohamedawnallah, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new blog post that comprehensively documents the author's Google Summer of Code 2025 project. The project's core focus was to significantly enhance Apache Beam's Python SDK by integrating connectors for various machine learning components, specifically vector databases like Milvus and feature stores such as Tecton, aiming to bolster support for advanced ML workflows. The PR also includes the necessary author metadata to correctly attribute the new blog content. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new blog post from a GSoC contributor about their project on Beam ML connectors. The post is well-structured and provides a good overview of the work, challenges, and learnings. My review includes several suggestions to improve grammar, clarity, and formatting in the markdown file to enhance readability for the audience. These include correcting verb tenses, fixing broken links, and rephrasing ambiguous or verbose sentences.
| someone can trigger post-commit Python workflows by updating the trigger files | ||
| in `.github/trigger_files` until near the middle of GSoC. I discovered there is | ||
| actually a workflows README document in `.github/workflows/README.md` that was | ||
| not referenced in the `CONTRIBUTING.md` file at the time of writing this post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Willing to follow-up shortly with a PR to update the CONTRIBUTING.md file to include reference to workflows README file so that future contributors can avoid this challenge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
303c1b4 to
bd1f0fa
Compare
|
Assigning reviewers: R: @liferoad for label website. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
1e7ae0b to
7540ffe
Compare
7540ffe to
f030843
Compare
|
cc: @damccorm |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - this is well written and a good final artifact! I just had one suggestion, but otherwise this looks great to me.
Co-authored-by: Danny McCormick <[email protected]>
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.