Set latest tag based on branch in sdk and docker snapshots #36298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Contributor
Author
|
I also see the workflow has been failing, it looks like it has to do with the time limit, I will take a look. |
Contributor
|
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
reviewed
Sep 26, 2025
| echo "DOCKER_TAG_LIST=${{ github.sha }},latest" >> $GITHUB_ENV | ||
| else | ||
| echo "DOCKER_TAG_LIST=${{ github.sha }}" >> $GITHUB_ENV | ||
| fi |
Contributor
There was a problem hiding this comment.
Can we update this to use the same conditional logic as the other workflow? It seems cleaner
Contributor
Author
There was a problem hiding this comment.
Done :)
Now all the images are tagged with the sha by default but latest just when working on main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the GitHub Actions workflows responsible for publishing Beam SDK and runner Docker images. The main goal is to ensure that the "latest" Docker tag is only applied when building from the
masterbranch, preventing non-master branches from overwriting the "latest" tag, fixes #24130 .A step was added to set the
LATEST_TAGvariable to,latestonly when the workflow runs on themasterbranch, ensuring the "latest" tag is only used in that context. Outside ofmasterit uses only the commit SHA.