GH-46627: [Swift] Support Decimal128
#46628
Closed
+124
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
Decimal128
dongjoon-hyun
force-pushed
the
PR-46627
branch
4 times, most recently
from
714cb23 to
15dbb62
Compare
Member
Author
Member
|
Let's do this in apache/arrow-swift. Cc: @raulcd |
Member
Author
|
It's a great news! |
Member
|
apache/arrow-swift#1 is done, I've imported the commits into https://github.com/apache/arrow-swift |
Contributor
Awesome!!! Thank you! |
|
|
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Jul 3, 2025
### What changes were proposed in this pull request? This PR aims to update `ArrowReader.swift` with `GH-54`. Please note that we cannot use `Apache Arrow Swift` directly yet because - It is still unable to support `Decimal`. - apache/arrow#46628 - It still uses `GRPC Swift` while we use `GRPC Swift 2`. ### Why are the changes needed? To be ready for the upstream release because `v21.0.0-rc0` tag is created. - https://github.com/apache/arrow-swift/releases/tag/v21.0.0-rc0 According to the release notes, this seems to be the only one which needs to catch up. ### Does this PR introduce _any_ user-facing change? No behavior change because this is a refactoring to suppress warning messages. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #207 from dongjoon-hyun/SPARK-52678. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR aims to support
Decimal128for Decimal type.What changes are included in this PR?
There are two decimal types;
Decimal128andDecimal256. Since Apache Spark usesDecimal128, this PR focus onDecimal128.Are these changes tested?
Pass the CIs.
Are there any user-facing changes?
Previously,
Decimaltype was not supported.Decimal128arrow-swift#17