Skip to content

chore: Add CONTRIBUTING.md #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2025
Merged

chore: Add CONTRIBUTING.md #30

merged 1 commit into from
Jun 7, 2025

Conversation

kou
Copy link
Member

@kou kou commented Jun 6, 2025

What's Changed

  • Use Conventional Commits
    • But use only fix (for patch release) , feat (for minor release) and chore (other changes) for easy to maintain
  • Need a GitHub issue for any change except "minor changes"

Closes #11.

@kou
Copy link
Member Author

kou commented Jun 6, 2025

@abandy Could you take a look at this?

@kou kou mentioned this pull request Jun 6, 2025
Open
raulcd
raulcd approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read through it and looks good to me. I'll let @abandy take a look before merging

@abandy
Copy link
Contributor

abandy commented Jun 7, 2025

lgtm!

@kou kou merged commit 00348c0 into apache:main Jun 7, 2025
1 check passed
@kou kou deleted the contributing branch June 7, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcd raulcd raulcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .github/CONTRIBUTING.md
3 participants
@kou @abandy @raulcd