[WIP] Use sol_get_sysvar instead of sol_get_<NAME>_sysvar, now with deserialization #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustopian
changed the title
rustopian
changed the title
rustopian
force-pushed
the
fixed-sysvar
branch
from
8949e2f to
cebd739
Compare
rustopian
changed the title
rustopian
force-pushed
the
fixed-sysvar
branch
from
af13972 to
dbb5321
Compare
rustopian
changed the title
Contributor
|
If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client |
rustopian
changed the title
rustopian
force-pushed
the
fixed-sysvar
branch
from
652ce5a to
1f2731a
Compare
Contributor
|
If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client |
rustopian
force-pushed
the
fixed-sysvar
branch
from
1f2731a to
7c66a7b
Compare
Contributor
|
If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client |
Contributor
Author
|
Replacing for sake of cleaner PR history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP]
This addresses Issue #235, fixing two issues with the original (reverted) PR:
from_raw_parts_mutwas being violated, in a way that miri considered safe, but which could have theoretically caused trouble in the future.mem::size_of::<Self>(), which was not always true.Rent, for example, contains au64, anf64and au8. In memory the compiler pads this struct to 24 bytes, but the runtime stores its contents as a 17‑bytebincodeserialization. Theget_sysvarcall thus returns only 17 bytes. Passing a 24‑byte buffer results in anOFFSET_LENGTH_EXCEEDS_SYSVARerror and undefined behavior when uninitialized bytes are interpreted as f64.In order to address this second issue, this PR provides 1‑byte‑aligned representations of the sysvars that match the on‑chain encoding. Then, we can zero-copy the bytes directly into those representations and convert them to the canonical structs without using
bincode.This is lightweight but bespoke deserialization to avoid requiring any given dependency.