Skip to content

feat(allocator): free_offset #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apfitzge merged 1 commit into from
Nov 6, 2025
Merged

feat(allocator): free_offset #29

apfitzge merged 1 commit into from
Nov 6, 2025

Conversation

@OliverNChalk
Copy link
Collaborator

@OliverNChalk OliverNChalk commented Nov 6, 2025 •
edited
Loading

Problem

  • It's common to want to free a given offset (as offsets are often passed within messages). This currently requires two unsafe calls.

Solution

  • Add free_offset that works with offsets instead of pointers.

@OliverNChalk OliverNChalk requested a review from apfitzge November 6, 2025 21:04
apfitzge
apfitzge approved these changes Nov 6, 2025
View reviewed changes
Copy link
Collaborator

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! can put this in v1.1 without breaking interface.

@apfitzge apfitzge merged commit d8dbbe0 into main Nov 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apfitzge apfitzge apfitzge approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OliverNChalk @apfitzge