Skip to content

join is unsafe #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apfitzge merged 1 commit into from
Sep 25, 2025
Merged

join is unsafe #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/allocator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ impl Allocator {
///
/// # Safety
/// - `worker_index` must be uniquely assigned to this worker thread/process.
pub fn join(path: impl AsRef<Path>, worker_index: u32) -> Result<Self, Error> {
pub unsafe fn join(path: impl AsRef<Path>, worker_index: u32) -> Result<Self, Error> {
let (header, file_size) = crate::init::join(path)?;

// Check if the worker index is valid.
Expand Down