sdk: Improve IntrospectedInstruction #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanmlittle
changed the title
febo
reviewed
Dec 6, 2025
| let offset = u16::from_le_bytes(unsafe { *(self.raw as *const [u8; 2]) }) as usize | ||
| * size_of::<IntrospectedInstructionAccount>() | ||
| + ADDRESS_BYTES; | ||
| let offset = |
Collaborator
There was a problem hiding this comment.
This bit in particular looks much nicer!
febo
reviewed
Dec 6, 2025
febo
reviewed
Dec 6, 2025
Co-authored-by: Fernando Otero <[email protected]>
Co-authored-by: Fernando Otero <[email protected]>
febo
reviewed
Dec 6, 2025
| pub struct IntrospectedInstruction<'a> { | ||
| pub raw: *const u8, | ||
| pub marker: PhantomData<&'a [u8]>, | ||
| marker: PhantomData<&'a [u8]>, |
LStan
reviewed
Dec 6, 2025
| /// | ||
| /// It is private and used internally within the `get_instruction_account_at` function, which | ||
| /// performs the necessary index verification. However, to optimize performance for users | ||
| /// who are sure that the index is in bounds, we have exposed it as an unsafe function. |
Contributor
There was a problem hiding this comment.
I guess, this comment was copied from get_instruction_account_at_unchecked and should not be here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made several improvements to the
IntrospectedInstructionAPI, including:num_account_metas(&self) -> usizehelper functionnew_unchecked(raw: *const u8) -> IntrospectedInstructionfunction that is consumed internally to avoid having to exposePhantomDataas a public fieldnum_instructionsreferusizeand removed all inline usize casts